Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sbt docker:stage work on Windows #824

Merged
merged 1 commit into from
Jun 24, 2016
Merged

Make sbt docker:stage work on Windows #824

merged 1 commit into from
Jun 24, 2016

Conversation

oporkka
Copy link
Contributor

@oporkka oporkka commented Jun 23, 2016 •
edited
Loading

Closes #823

This change is Reviewable

@lightbend-cla-validator
Copy link

Hi @oporkka,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@muuki88
Copy link
Contributor

muuki88 commented Jun 23, 2016

Were you able to run the sbt scripted docker/* tests?

Thanks for the extensive documentation on this issue :)

@oporkka oporkka mentioned this pull request Jun 23, 2016
Closed
@oporkka
Copy link
Contributor Author

oporkka commented Jun 23, 2016

My pleasure!

sbt scripted docker/* fails both in this branch and current master branch. There's stacktrace like

[info] java.io.IOException: Cannot run program "C:\Users\Oskari\AppData\Local\Temp\sbt_a8dde3df\simple-app\target\universal\stage\bin\simple-app" (in directory "C:\Users\Oskari\AppData\Local\Temp\sbt_a8dde3df\simple-app\target\universal\stage"): CreateProcess error=193, %1 is not a valid Win32 application
[info]  at java.lang.ProcessBuilder.start(ProcessBuilder.java:1048)
[info]  at sbt.SimpleProcessBuilder.run(ProcessImpl.scala:349)
[info]  at sbt.AbstractProcessBuilder.$bang(ProcessImpl.scala:160)
[info]  at sbt.AbstractProcessBuilder.getString(ProcessImpl.scala:133)
[info]  at sbt.AbstractProcessBuilder.$bang$bang(ProcessImpl.scala:136)
[info]  at $e918e65b4ee909c26cd3$$anonfun$$sbtdef$1.apply(C:\Users\Oskari\AppData\Local\Temp\sbt_a8dde3df\simple-app\build.sbt:10)
[info]  at $e918e65b4ee909c26cd3$$anonfun$$sbtdef$1.apply(C:\Users\Oskari\AppData\Local\Temp\sbt_a8dde3df\simple-app\build.sbt:7)
[info]  at scala.Function1$$anonfun$compose$1.apply(Function1.scala:47)
[info]  at sbt.$tilde$greater$$anonfun$$u2219$1.apply(TypeFunctions.scala:40)
[info]  at sbt.std.Transform$$anon$4.work(System.scala:63)
[info]  at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:228)
[info]  at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:228)
[info]  at sbt.ErrorHandling$.wideConvert(ErrorHandling.scala:17)
[info]  at sbt.Execute.work(Execute.scala:237)
[info]  at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:228)
[info]  at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:228)
[info]  at sbt.ConcurrentRestrictions$$anon$4$$anonfun$1.apply(ConcurrentRestrictions.scala:159)
[info]  at sbt.CompletionService$$anon$2.call(CompletionService.scala:28)
[info]  at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[info]  at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[info]  at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[info]  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[info]  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[info]  at java.lang.Thread.run(Thread.java:745)
[info] Caused by: java.io.IOException: CreateProcess error=193, %1 is not a valid Win32 application
[info]  at java.lang.ProcessImpl.create(Native Method)
[info]  at java.lang.ProcessImpl.<init>(ProcessImpl.java:386)
[info]  at java.lang.ProcessImpl.start(ProcessImpl.java:137)
[info]  at java.lang.ProcessBuilder.start(ProcessBuilder.java:1029)
[info]  at sbt.SimpleProcessBuilder.run(ProcessImpl.scala:349)
[info]  at sbt.AbstractProcessBuilder.$bang(ProcessImpl.scala:160)
[info]  at sbt.AbstractProcessBuilder.getString(ProcessImpl.scala:133)
[info]  at sbt.AbstractProcessBuilder.$bang$bang(ProcessImpl.scala:136)
[info]  at $e918e65b4ee909c26cd3$$anonfun$$sbtdef$1.apply(C:\Users\Oskari\AppData\Local\Temp\sbt_a8dde3df\simple-app\build.sbt:10)
[info]  at $e918e65b4ee909c26cd3$$anonfun$$sbtdef$1.apply(C:\Users\Oskari\AppData\Local\Temp\sbt_a8dde3df\simple-app\build.sbt:7)
[info]  at scala.Function1$$anonfun$compose$1.apply(Function1.scala:47)
[info]  at sbt.$tilde$greater$$anonfun$$u2219$1.apply(TypeFunctions.scala:40)
[info]  at sbt.std.Transform$$anon$4.work(System.scala:63)
[info]  at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:228)
[info]  at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:228)
[info]  at sbt.ErrorHandling$.wideConvert(ErrorHandling.scala:17)
[info]  at sbt.Execute.work(Execute.scala:237)
[info]  at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:228)
[info]  at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:228)
[info]  at sbt.ConcurrentRestrictions$$anon$4$$anonfun$1.apply(ConcurrentRestrictions.scala:159)
[info]  at sbt.CompletionService$$anon$2.call(CompletionService.scala:28)
[info]  at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[info]  at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[info]  at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[info]  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[info]  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[info]  at java.lang.Thread.run(Thread.java:745)

@muuki88 muuki88 merged commit b4d7cd1 into sbt:master Jun 24, 2016
@muuki88
Copy link
Contributor

muuki88 commented Jun 24, 2016

The stacktrace looks strange. We need some ci for windows+docker :/ Hopefully appveyor will over something in the future.

@muuki88
Copy link
Contributor

muuki88 commented Jun 24, 2016

thanks for fixing this :)

@oporkka oporkka deleted the fix_823_sbt_docker_stage_fails_on_windows branch June 27, 2016 13:14
@muuki88 muuki88 mentioned this pull request Jul 6, 2016
Closed
@oporkka oporkka restored the fix_823_sbt_docker_stage_fails_on_windows branch July 12, 2016 09:15
@oporkka oporkka deleted the fix_823_sbt_docker_stage_fails_on_windows branch July 12, 2016 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oporkka @lightbend-cla-validator @muuki88